Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

225 deploy amber contracts to foucoco and test that it works #13

Conversation

ashneverdawn
Copy link

No description provided.

@ashneverdawn ashneverdawn requested a review from a team August 17, 2023 16:50
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried doing the setup by following the steps you put in the README and updated it with my findings along the way.
I changed the directory structure and deduplicated some code to make it more straightforward to use.

However, it's not clear to me what this PR is supposed to achieve as it does not contain a description and the linked ticket #225 does not specify how we want to test the contracts. I think ideally we should first agree on a testing approach in a separate ticket.

@TorstenStueber
Copy link
Contributor

The problem is that we didn't properly define yet what we need to do for testing and Hugo was exploring here. It makes sense to me and I will incorporate this into the latest changes that I added to wasm-deploy. They should make some of the setup here easier to reproduce.

@ebma
Copy link
Member

ebma commented Aug 21, 2023

Okay so you are picking some of the changes of this PR and applying it to another? Can you maybe link to the branch or commit so that it's easier to follow @TorstenStueber?

@TorstenStueber
Copy link
Contributor

@ebma This is a current branch but does not include the tests yet: #19. However, it contains some of the other changes so that it should be easy to run wasm-deploy out of of the box for Nabla.

@TorstenStueber
Copy link
Contributor

We can close this PR now as it has been replaced by #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy amber contracts to foucoco and test that it works
3 participants